-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Sphinx fixes #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx fixes #2681
Conversation
in 75522ec I removed all the transformations between |
@nicolaskruchten still WIP but you can already take a look at the artifact to see if everything's ok (the problems mentioned in #2652 seem to be solved I think).
|
OK great! Thank you :)
I think we used to do this, so that's not a problem for me. Also note I merged |
OK, I think this one is ready now. Is it worth a changelog item (as a bug fix? Not sure we want to explain all the graph_objs/graph_objects problems :-)) |
No need for a changelog item, nope! Should this target doc-prod instead of master so it gets out immediately? 💃 for a squash-and-merge rather than a normal merge please :) |
We can probably close this one out now, thanks for merging the other one. This stuff will get back-merged into |
I'll be working on fixing the sphinx documentation, but this is a first PR to store the generated files in a sphinx artifact so that reviewers can check the result without checking out the branch. With this idea in mind, I did not zip the output so that the html doc can be browsed directly on circleCI.